Skip to content

fix: sim export_unittest for windows #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 7, 2025
Merged

fix: sim export_unittest for windows #655

merged 3 commits into from
Jul 7, 2025

Conversation

StefanThoene
Copy link
Collaborator

@StefanThoene StefanThoene commented Jul 4, 2025 •
edited
Loading

Description

Fix unittest of simulation export for windows systems

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: add optical property)
  • I have agreed with the Contributor License Agreement (CLA).

@StefanThoene StefanThoene changed the title fix sim export_unittest for windows fix: sim export_unittest for windows Jul 4, 2025
@StefanThoene StefanThoene self-assigned this Jul 4, 2025
@StefanThoene StefanThoene marked this pull request as ready for review July 4, 2025 11:51
@github-actions github-actions bot added testing Anything related to tests bug Something isn't working labels Jul 4, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (011c9ae) to head (efb1621).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #655   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          39       39           
  Lines        5574     5574           
=======================================
  Hits         4962     4962           
  Misses        612      612

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@StefanThoene StefanThoene requested a review from pluAtAnsys July 7, 2025 06:19
@pluAtAnsys pluAtAnsys merged commit 502c500 into main Jul 7, 2025
24 checks passed
@pluAtAnsys pluAtAnsys deleted the fix/unittest-simexport branch July 7, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pluAtAnsys pluAtAnsys pluAtAnsys approved these changes

Assignees

@StefanThoene StefanThoene

Labels
bug Something isn't working testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StefanThoene @pluAtAnsys @pyansys-ci-bot